yokemura / Magical8bitPlug2

GNU General Public License v3.0
304 stars 19 forks source link

[BUG] MIDI Controller Pitch/Mod Wheel Detection #10

Closed maximilian-hub closed 3 years ago

maximilian-hub commented 4 years ago

Describe the bug This bug relates to realtime performance with a MIDI controller. Changes to the wheels will not take effect unless they are moved after a note is already playing.

To Reproduce Steps to reproduce the behavior:

  1. Open an Magic8Bit track in any DAW (I tested Studio One, Reaper64, and Garageband)
  2. Set the pitch wheel to its lowest value (by default this should result in a pitch bend of -2)
  3. Play a C
  4. Hear that the note that plays is a C, instead of a Bb

(5.) While still holding the note, return the pitch wheel to neutral position (6.) Hear the pitch update as soon as the wheel moves

Expected behavior I expected the plugin to detect the position of the wheel before the note was played.

Screenshots This is what I'm playing in both audio samples. You can see for the second note, the pitch wheel is depressed before the note is played:

Screen Shot 2020-09-13 at 12 36 59 PM

Audio What I hear with Magic8Bit What I hear with other VSTs

Your environment (please complete the following information):

Additional context It's not a big deal for the sample I gave, as you could just play the Bb and bend it up to a C. But there are a lot of other applications in performing where I rely on this! The same problem applies to the mod wheel.

yokemura commented 4 years ago

Noted.

Probably It's not taking the initial pitch/mod value passed with the note on event. I'll check it out.