search

yokemura / Magical8bitPlug2

GNU General Public License v3.0
301 stars 19 forks source link

Vibrato issue #27

Closed flubber2077 closed 2 years ago

flubber2077 commented 2 years ago

Describe the bug Rate control of vibrato is reversed from expected behavior (vibrato gets slower as control is increased towards 1)

To Reproduce Steps to reproduce the behavior: On default settings, turning depth up until modulation is audible, sweeping the rate down increases the speed and turning it up decreases.

Expected behavior As rate is increased, the rate of the vibrato increases in hertz.

Your environment (please complete the following information):

yokemura commented 2 years ago

Thanks for your report and sorry for my slow response. You are correct in a sense that the label "rate" and the actual behavior don't match.

But my intended behavior is that the slider sets the cycle length, so what's wrong is the label. It should say "cycle length" or "time".

flubber2077 commented 2 years ago

I like that just as much! Thanks for your time.