yokemura / Magical8bitPlug2

GNU General Public License v3.0
301 stars 19 forks source link

[FEATURE] Increase maximum pitch bend range to 48 #38

Open NanoDano opened 1 year ago

NanoDano commented 1 year ago

Is your feature request related to a problem? Please describe. I have a ROLI Seaboard and the default pitch bend range for gliding is 48. The maximum pitch bend range allowed in the synth is 24.

Describe the solution you'd like The pitch bend range slider should go up to 48.

Describe alternatives you've considered Modifying the configuration of my ROLI Seaboard to match the same pitch bend range.

Additional context

I am able to build the plugin locally and I am willing to submit a pull request for the code. However, I couldn't find exactly where it is. I am assuming it is in Source/BendParamsComponent.cpp, perhaps on line 44. If you could point me in the right direction I can try to adjust it.

ROLI Dashboard for configuring the hardware

2023-02-12_08-47-46

Pitch bend parameter

2023-02-12_08-53-59
Archonic944 commented 1 year ago

If you want to modify the range, you only really have to modify a single line in the PluginProcessor.cpp file. This file initializes all the settings for the plugin as well as min and maxes. :)

It's actually super easy:

Screenshot 2023-06-20 at 11 06 17 PM