yokemura / Magical8bitPlug2

GNU General Public License v3.0
301 stars 19 forks source link

Added 'bend resolution' slider #40

Closed Archonic944 closed 4 months ago

Archonic944 commented 1 year ago

This allows for pitch bend to be quantized into semitones (or smaller increments) for a more 'chipped' feel.

Things to consider:

I hope this plugin is still being maintained! A ton of people (like me) rely on it for a simple, cross-platform chiptune sound that isn't crazy expensive or using an emulator. :)

Archonic944 commented 1 year ago

Changed this a little bit; it's no longer a slider, it's now 2 checkboxes. check commit description for more details.

yokemura commented 6 months ago

Thanks for your pull request, and i'm sorry for not responding for months.

You can get what you want with Custom Envelopes or Monophonic Mode.

By specifying series of semitones to Custom Pitch Envelope you can get the auto bending with semitone restriction. On top of that you can also have it time quantized as well. I believe the time quantization is as well important as the pitch quantization for a real chip feelings.

With Monophonic Mode you can change the pitch without restarting the envelope by overlapping the notes slightly. To apply a quantized pitch bend this will be easier and you'll have more granularity over the transition.

I know these methods are a bit more cumbersome than your proposal, but I want to be somewhat thoughtful in adding more functionality to my plugin.

Archonic944 commented 6 months ago

Thank you for the reply. I get that you don't want to fill up your plugin with unnecessary features, so it's OK that you don't want to merge my change. Although, I do kind of regret the way I went about this. If I had to do it again, I think I would just add a checkbox to quantize the automatic portamento, not auto or pitch bend. The only way to do that is this (image), and it would force you to not use the built-in portamento option:

image

Is there a way to do this within the current plugin? And do you think that would be a good proposal instead?

yokemura commented 6 months ago

I believe that my suggestion also works with Portamento as well. Just set the Monophonic Mode to Legato instead of Portamento. Then no interporation of pitch happens while the envelope and the wave phase are retained.

Archonic944 commented 6 months ago

Ok, thank you for the tip.

On Sun, Jan 28, 2024 at 1:04 AM Takeshi Yokemura @.***> wrote:

I believe that my suggestion also works with Portamento as well. Just set the Monophonic Mode to Legato, and no interporation of pitch will happen while the envelope and the wave phase retained.

— Reply to this email directly, view it on GitHub https://github.com/yokemura/Magical8bitPlug2/pull/40#issuecomment-1913465426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AND2D2E3HROVE6RQ3QXZUBDYQXS7NAVCNFSM6AAAAAAZODI6Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQ3DKNBSGY . You are receiving this because you authored the thread.Message ID: @.***>