search

yokester98 / pe

0 stars 0 forks source link

Undo command does not function as stated #2

Open yokester98 opened 2 years ago

yokester98 commented 2 years ago

According to the UG, the undo function does the following:

image.png

I attempted to use multiple addMembership command in separate commands (not command chain), followed by a single undo, which resulted in all of the previous addMembership being undone as well. This does not follow what the function is supposed to do, which is to undo last modification made to the clients list.

Steps to reproduce the bug:

addMembership 1 m/gold d/2022-02-03

image.png

addMembership 2 m/gold d/2022-02-03

image.png

addMembership 3 m/gold d/2022-02-03

image.png

undo

image.png

soc-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Undo function undoes multiple actions even when not in command chain

After adding a person to the app, I used the pay command, followed by the undo command. This resulted in both the add and pay command being undone, when it should only have undone the pay command.

Steps to reproduce bug:

add n/balakrishnan p/123123 e/123@nus.edu a/NUS

image.png

pay 1

image.png

undo

image.png

[original: nus-cs2103-AY2122S2/pe-interim#351] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Whilst this two issues are on the same undo command, how certain is the team that by fixing 1 issue, the other issue is automatically fixed?

These are two different cases where different commands are executed first before using the undo command. For example, in this issue, the addMembership command was tested and deemed to be faulty. However, in the other issue, the add and the pay commands were tested and deemed to be faulty. Furthermore, I have realised that not every command faced this undo issue. Hence, it may not be accurate to deem that these are duplicates as they are caused by independent commands (addMembership vs add and pay).

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]