yokoffing / Betterfox

Firefox user.js for speed, privacy, and security. Your favorite browser, but better.
MIT License
6.11k stars 150 forks source link

Disqus in "Strict" mode doesn't work #293

Closed DoTrONoL closed 5 months ago

DoTrONoL commented 6 months ago

BEFORE YOU BEGIN

I have attempted the following troubleshooting suggestions:

REPORT

Describe the bug I want to see Discus comment section in any website that I open when I'm in "strict" mode in about:preferences#privacy, but I can't see it. When I use this settings: user_pref("browser.contentblocking.category", "standard"); It does work properly, as expected, but I don't want to use "standard" mode, I want to keep it in "strict". I know that I can make a exception and I have tried, but every iteration didn't work properly. Only when I changed content blocking to "standard".

This is what I tried in MY OVERRIDES:

user_pref("urlclassifier.trackingSkipURLs", "*.disqus.com, *.disquscdn.com, *.reddit.com, *.twitter.com, *.twimg.com, *.tiktok.com");
user_pref("urlclassifier.features.socialtracking.skipURLs", "*.disqus.com, *.disquscdn.com, *.instagram.com, *.twitter.com, *.twimg.com");

As I could not fix by myself, I'm asking for help.

Example Website: AMD launches EPYC 4004 CPUs on AM5 package: up to 16 Zen4 cores & 3D V-Cache for $699 - VideoCardz.com

To Reproduce Steps to reproduce the behavior:

1. Go to any website that uses Disqus
2. Scroll to the bottom of the site
3. You see that comment section doesn't appear OR It says (if you keep "strict" value): "Disqus seems to be taking longer than usual. Reload?"

Expected behavior Discus comment section shows in any website that uses it when I'm using "Strict" mode in about:preferences#privacy.

Desktop (please complete the following information):

yokoffing commented 6 months ago

I'm able to reproduce, but I'm unsure why Firefox discriminates between Disqus and the others.

yokoffing commented 5 months ago

It could be a bug in Firefox. From looking at the console, it seems Firefox still marks Disqus as Tracking even after adding an exception. And socialtracking.skipURLs isn't needed because Firefox ETP only categorizes Disqus as Tracking and not Social Media Tracking.

Similarly, https://www.bing.com/shop was broken in Firefox Nightly Strict mode. I opened a bug report that hasn't been touched in a year. But I just tested today and it seems to be working.

So for now, you'd have to use Standard or Custom ETP where Tracking content is set to Only in private windows.

DoTrONoL commented 5 months ago

Ok. So we need to wait for a 'fix' from Firefox, then. Should I (or you) report to them?

Does It have a line code for user.js, or should I disable the ETP config in the user.js and set it manually in my Firefox? If that exist and, I appreciate it if you could give me this line code for the Custom ETP, getting the same benefits as Strict but with only this option "Only in private windows" changed.


Idk if it could be considered as 'completed' as we're the ones waiting for a fix from Firefox, so I'll let it up to you to close the issue. Thx by your effort.

yokoffing commented 5 months ago

Should I (or you) report to them?

Yes, open a bug report. https://bugzilla.mozilla.org/enter_bug.cgi

Does It have a line code for user.js, or should I disable the ETP config in the user.js and set it manually in my Firefox?

You add user_pref("browser.contentblocking.category", "custom"); at the bottom of your user.js, in the My Overrides section.

getting the same benefits as Strict but with only this option "Only in private windows" changed.

If you still want all the other privacy benefits of Strict ETP, then you need to: 1) Go to Securefox 2) Press CTRL + F 3) Search for enabled with "Strict" 4) Add them to the bottom of your user.js in the My Overrides section without the //, except for privacy.trackingprotection.enabled.

DoTrONoL commented 5 months ago

Thx. To be exactly, I had to use this line in My Overrides to make it to work properly user_pref("privacy.trackingprotection.enabled", false); as it wasn't coming disabled by default in "custom"

I read the Bugzilla forum and right now we have 6 reports if you search for "disqus comment" in this link. The most active report is this one. So I decided not to open a new issue, rather I'm informing our context (this issue) to that bug report.

yokoffing commented 5 months ago

I had to use this line in My Overrides to make it to work properly user_pref("privacy.trackingprotection.enabled", false);

Ahh, yeah. That makes sense, because Firefox also has privacy.trackingprotection.pbmode.enabled as a pref.

I don't advocate for Custom, nor do I use it. But you're correct here.

I decided not to open a new issue

Good job searching for any related issues first. Hopefully they resolve it soon.