yokoffing / Betterfox

Firefox user.js for speed, privacy, and security. Your favorite browser, but better.
MIT License
6.08k stars 150 forks source link

Firefox Weather Widget not being blocked by Betterfox #311

Closed FifthWit closed 1 month ago

FifthWit commented 3 months ago

BEFORE YOU BEGIN

I have attempted the following troubleshooting suggestions:

REPORT

Describe the bug A clear and concise description of what the bug is. A new FireFox feature (for me) added a widget with the weather at the top left of the new tab screen on a fresh install To Reproduce Steps to reproduce the behavior:

1. Go to 'Download FireFox'
2. Install BetterFox
3. Open New Tab
4. Look at the top left and it should have a weather widget in specific mine is sponsered by AccuWeather

Expected behavior A clear and concise description of what you expected to happen. The Widget would be gone along with all the data it takes Screenshots If applicable, add screenshots to help explain your problem. image for gh issue Desktop (please complete the following information):

Additional context Add any other context about the problem here. unsure if everyone has this but at least on the most recent version its appearing for me

yokoffing commented 3 months ago

Documented, but doesn’t seem to be enabled in stable just yet: https://github.com/yokoffing/Betterfox/blob/abe7e9d4d8620d66577c6b45cfb4ebdcbbfbf285/Peskyfox.js#L290-L291

You can still turn it off in about:config or adding it to your personal user.js.

There also should be UI for this in the settings, if there isn't already.

yokoffing commented 2 months ago

This finally landed for me in today's update v. 130.

winter-again commented 2 months ago

Not sure if helpful, but (in ref. to the commit above) I had to specify browser.newtabpage.activity-stream.system.showWeather as false too to get the weather widget to go away.

yokoffing commented 2 months ago

@winter-again I've tested on two systems with vanilla Firefox stable and once in Nightly, and I only had to use browser.newtabpage.activity-stream.showWeather. I've also confirmed that this is the pref that changes if you disable the Weather widget from the new tab page.

system.showWeather removes it altogether as an option from the gear icon on the new tab page (hides it in the UI).