Certain replies to tweets containing videos blocked when clicked

Lordiun commented 9 months ago

Prerequisites

[X] I am not using any other content blockers alongside uBO (Privacy Badger, AdGuard, Ghostery, Adblock Plus, etc.)
[X] I verified that this is not a known filter issue
[X] This is not a support issue or a question
[X] I performed a cursory search of the uBO issue tracker to avoid opening a duplicate issue
[X] The issue is not present after wholly disabling uBO in the browser

I tried to reproduce the issue when...

[X] uBO is the only extension
[X] uBO with default lists/settings
[X] using a new, unmodified browser profile

Specific URL(s) where the issue occurs

https://twitter.com/Alrz612/status/1728527621867130937

https://twitter.com/smooyacs/status/1728364037958987979

Description

From what i can tell, while using yokoffing's annoyance list when you click on a reply on a tweet specifically containing a video you have a chance of the reply you clicked on being blocked and it ends up being very confusing where you're actually replying. I believe i have narrowed it down to the rule below creating the issue for me as creating an exception seems to fix it. But why this seems to happen to some comments and not others i cannot figure out.

! [User] follows !twitter.com,twitter3e4tixl4xyajtrzo62zg5vztmjuricljdp2c5kshju4avyoid.onion##article div>svg>g>[d^="M17.863 13.44c1.477"]:upward(article)

Steps to Reproduce

Go to the main tweets of the replies that i have linked
click on either reply that i have linked to

Logger Output

<details><summary>Logger output</summary>

| | | | | | | | |
|:--- |:--- |:--- |:--- |:--- |:--- |:--- |:--- |
| +19 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +17 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +14 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +10 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +7 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +7 | ##article div>svg>g>[d^="M17.863 13.44c1.477"]:upward(article) |  | twitter.com |  | get | dom | `https://twitter.com/Alrz612/status/1728527621867130937` |
| +7 | ##[aria-label$="trending now" i] |  | twitter.com |  | get | dom | `https://twitter.com/Alrz612/status/1728527621867130937` |
| +6 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +6 | ##[aria-label="relevant people" i]:upward(1) |  | twitter.com |  | get | dom | `https://twitter.com/Alrz612/status/1728527621867130937` |
| +3 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +3 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
| +3 | ##html:style(overflow:auto!important) |  | twitter.com |  | get | dom | `https://twitter.com/Alrz612/status/1728527621867130937` |
| +2 | ##+js(trusted-set-cookie, d_prefs, MjoxLGNvbnNlbnRfdmVyc2lvbjoyLHRleHRfdmVyc2lvbjoxMDAw) |  | twitter.com |  | get | scriptlet | `https://twitter.com/Alrz612/status/1728527621867130937` |
| +2 | \|\|ads-twitter.com^ | -- | twitter.com | 3 | get | script | `https://static.ads-twitter.com/uwt.js` |
| +0 | \|\|twitter.com/i/api/1.1/jot | -- | twitter.com | 1 | post | xhr | `https://twitter.com/i/api/1.1/jot/client_event.json` |
</details>

Expected behavior

Being able to see the reply you have pressed on as the tweet "in focus"

Actual behavior

the reply you click gets hidden and you can no longer read it

uBlock Origin version

1.53.0

Browser name and version

Firefox 120.0

Operating System and version

No response

yokoffing commented 9 months ago

If I understand you correctly, then I am not able to reproduce. But I may not understand the issue 100% 🙃

Can you send:

A screenshot of the way they should look
A screenshot of what the breakage is.

Thanks

Lordiun commented 9 months ago

Absolutely mate, I'm sure my wording wasn't the best as well, apologies. Hopefully this demonstrates it (note the twitter url and the "replying to" showing that I've clicked on the replies to try reply to them and not the main post) https://imgur.com/a/2mq4xP9

yokoffing commented 9 months ago

Thank you for reporting! I've commented out the rule

! [User] follows
twitter.com,twitter3e4tixl4xyajtrzo62zg5vztmjuricljdp2c5kshju4avyoid.onion##article div>svg>g>[d^="M17.863 13.44c1.477"]:upward(article)

until I find a replacement.

sinazadeh commented 1 month ago

Unfortunately, I experienced a similar issue with uBlock Origin. Whenever I click on a tweet, I can only see the replies and not the original tweet. Also, the number of likes and reports are not shown. Here's a temporary fix that worked for me:

no-cosmetic-filtering: x.com true
no-cosmetic-filtering: twitter.com true

yokoffing commented 1 month ago

https://github.com/yokoffing/filterlists/issues/151#issuecomment-2233883897

yokoffing / filterlists