Closed AceFire6 closed 9 years ago
Yay for everything else though. :tada:
:-1: I don't see the advantage.
Sure, you don't need to have node installed, but that wasn't really an issue, was it? Everyone who deploys this has node on their machine.
There is now a file called doorservice.css
that appears to contain bootstrap. Does it contain some other stuff too? How would I know?
:+1: for the error handler, though.
The bootstrap stuff in doorservice.css is uncss'ed, so it's only the bootstrap stuff we need/use. Maybe we should have kept it in two separate files.
Sure, you don't need to have node installed, but that wasn't really an issue, was it? Everyone who deploys this has node on their machine.
Time it takes to run npm install
on the Pi:
real 10m21.314s
user 5m4.420s
sys 0m45.390s
I was deploying it manually by getting the latest copy of doorservice and running build.sh
, which meant waiting long for a build to happen.
There is now a file called doorservice.css that appears to contain bootstrap. Does it contain some other stuff too? How would I know?
Yeah, that's nasty.
Time it takes to run npm install on the Pi
You don't have to run it on the Pi.
:sparkles: No lint errors found. :sparkles:
OK, that's looking better.
But the uncss'd CSS still seems to have appeared out of thin air. I'd like to see some documentation (ideally in the form of a script) for re-creating it in the future. This doesn't have to happen at build time.
In the far future, I imagine we'll be deploying doorservice with yodeploy, and any build-time constraints will vanish.
I promised I'd look at scripting the uncss'ing.
uncss stuff is merged, so it's probably worth updating this PR, or creating a new one.
:sparkles: No lint errors found. :sparkles: