search

yola / gulp-static-i18n

Gulp plugin for internationalization of static assets.
MIT License
5 stars 8 forks source link

Add translator for json files #8

Closed beck closed 9 years ago

beck commented 9 years ago

Closes https://github.com/yola/gulp-static-i18n/issues/2

beck commented 9 years ago

Errr... I'm not happy about setting a jshintrc. All tests pass locally using jsgreat (and using the same jshint version as travis) but travis' jshint is suddenly chocking on pre-existing code—code that has already in master and passed linting. Annoying. Next version of jshint I'll reset the last two commits and hopefully all is well.

beck commented 9 years ago

ping @euwest or @imorrison or @kahnjw - this change lets me remove grunt and remove all gettext calls from our json

adrianmoisey commented 9 years ago

If you pin to jsgreat 0.1.4 then tests should pass again. I assume the breakage is the line length limit introduced in jsgreat 0.1.5.

imorrison commented 9 years ago

:+1: ... but I think jsgreat is still great.

beck commented 9 years ago

Thanks @adrianmoisey - that did the trick.

Since I'd like a second thumb, I decided to make it worth while by adding some docs and bumping the version.

beck commented 9 years ago

:bell:

imorrison commented 9 years ago

:+1: