search

yola / pixabayjs

A Javascript Client for the Pixabay API
MIT License
17 stars 6 forks source link

Remove host, protocol options, only support url in RequestFactory #14

Closed LionOps closed 9 years ago

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

kahnvex commented 9 years ago

I'm confused, why relative path?

LionOps commented 9 years ago

A better name is welcomed.

kahnvex commented 9 years ago

A relative path is something like ./relative/path, relative/path, or ../some/path. Anything starting with / is not a relative path. I think we should simply store one field, that we parse using the URL module, when we add a pefix, querystring, etc.

That field can have the protocol and host, or leave it off.

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

Hkly commented 9 years ago

:+1: