search

yola / pixabayjs

A Javascript Client for the Pixabay API
MIT License
17 stars 6 forks source link

[WIP] Use ES6. #23

Closed LionOps closed 9 years ago

LionOps commented 9 years ago

The WIP part is to test to make sure this still works where we are using it, as well as looking up Airbnb's style guide for how they handle ES6. I'm not convinced that I did everything well.

Also, the Travis needs fixed to work properly.

The code is ready for review.

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

kahnvex commented 9 years ago

I'm still not a fan of using ES6 style modules until it is compatible with CommonJS. We use CommonJS and heavily rely on it. Why switch to something new that is incompatible? CommonJS is working fine, right?

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

snitch commented 9 years ago

:sparkles: No lint errors found. :sparkles:

LionOps commented 9 years ago

Closing in favor of #27