yola / pixabayjs

A Javascript Client for the Pixabay API
MIT License
17 stars 6 forks source link

Update dependencies #58

Open Jaylooker opened 6 years ago

Jaylooker commented 6 years ago

Dependencies haven't been update in 2 years. Here are the current one's with security issues:

Ran suggested npm install superagent@3.8.3 (with browsify updated) Got error log on test:

  Pixabayjs
    authenticate
      √ sets the client's key
    imageResultList
      √ returns a ResultList
      √ uses the image url
    videoResultList
      √ returns a ResultList
      √ uses the video url
ResultList
    initial request for page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    previous() on page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    next() on page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    previous() on page 2
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    second next() on page 1
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

    next() on page 2
      × "before all" hook
        TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

PhantomJS 2.1.1 (Windows 8 0.0.0): Executed 11 of 21 (6 FAILED) (0.143 secs / NaN secs)
TOTAL: 6 FAILED, 5 SUCCESS

1) "before all" hook
     ResultList initial request for page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

2) "before all" hook
     ResultList previous() on page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

3) "before all" hook
     ResultList next() on page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

4) "before all" hook
     ResultList previous() on page 2
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

5) "before all" hook
     ResultList second next() on page 1
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

6) "before all" hook
     ResultList next() on page 2
     TypeError: undefined is not an object (evaluating 'this.res.response.xhr') (.../Temp/src/response-handler.js:34:6 <- .../Temp/231ab8703b86fa5280c375577a8b093d.browserify:26147)

npm ERR! Test failed.  See above for more details.

Maybe superagent has deprecated code or something else.

Reverted back to base project (with browsify updated) Ran suggested npm install --save-dev mocha@5.2.0 Test had no errors. Could possibly be added to #57.

The Karma[dev]-> ... ->hoek dependency may be a complex issue. I have not looked into it.