search

yola / vectorify

A js package for transforming .svgs into modules so you can require them
MIT License
0 stars 0 forks source link

Overly simplistic escaping #3

Open stefanor opened 8 years ago

stefanor commented 8 years ago

https://github.com/yola/svgify/blob/a7ef8970be15e28c4a36fa9f3c1e39ea3b3a9a61/vectorify.js#L5-L8

Is this correct? Having 2 backslashes for both of those seems a bit odd. Also, what about backslash characters?.

Usually in this sort of situation, one wants to:

Replace \ with \\, then replace " with \".

stefanor commented 8 years ago

@AhoyM: Initially commented, on your PR, here https://github.com/yola/yonav/pull/105#discussion_r36356485.

But the code has since moved.

ahoym commented 8 years ago

ping @kahnjw, original author