search

yola / yodeploy

Python library for deployment
4 stars 0 forks source link

Wrong shebang in scripts in virtualenv/bin directory #208

Closed kosmos342 closed 7 years ago

kosmos342 commented 7 years ago

celery for importer(/srv/importer/live/virtualenv/bin/celery) has strange shebang:

#!/var/lib/jenkins/workspace/Build-importer/virtualenv/bin/python

expected:

##!/usr/bin/env python3.5

importer project uses Python 3.5. Same problem with importservice(python 3.5.2 also)

Looks like problem here: https://github.com/yola/yodeploy/blob/7ec27f895aee3a5d3ecc4efd55c19b7a111b2b5b/yodeploy/virtualenv.py#L174-L176

stefanor commented 7 years ago

Yeah, this is a long known issue. Lazy answer: don't rely on the shebangs. You can't put relative paths in shebangs, and so we can't really do much better.

blaix commented 7 years ago

we can't really do much better.

does that mean this should be closed?

stefanor commented 7 years ago

Yeah, it's WONTFIX territory.