search

yolk / valvat

Validates european vat numbers. Standalone or as a ActiveModel validator.
MIT License
321 stars 80 forks source link

fix The given SOAPAction checkVat does not match an operation. #105

Closed lubosch closed 3 years ago

lubosch commented 3 years ago

For some unknown reason this gem now throws this error: The given SOAPAction checkVat does not match an operation.

The reason for this is that savon inserts a SOAPaction header that brokes it. This workaround removes that header and the error is no longer risen. I didn't find any other workaround to remove this error. For more info look here:

Savon::SOAPRequest#configure_headers

Quaresma1997 commented 3 years ago

Failed specs. Can you please run them again?

lubosch commented 3 years ago

I have no idea what truffleruby is and I didn't touch normalize function so probably sth else should be fixed also

Quaresma1997 commented 3 years ago

Ok, for now I'll fork your PR and use it on my project.

yolk commented 3 years ago

Thanks @lubosch for the fix. I can confirm the error. Seems to be a change in the WDSL-file, which savon isn't handling correctly.

The error in truffleruby seems to be completly unrelated.

Quaresma1997 commented 3 years ago

Will you send a new release?

yolk commented 3 years ago

Yes. Give me some minutes.

yolk commented 3 years ago

Just released v1.1.2 including the fix.

hagi commented 3 years ago

@yolk any chance for 1.0.2 version with this fix for legacy systems?