Replace GeoIP with pygeoip

yolothreat / utilitybelt

A Python library for being a CND Batman....

MIT License

35 stars 12 forks source link

Replace GeoIP with pygeoip #25

Closed krmaxwell closed 9 years ago

krmaxwell commented 9 years ago

This will simplify installation (no libgeoip-dev required) and is otherwise a drop-in replacement. See http://pythonhosted.org/pygeoip/ for more.

krmaxwell commented 9 years ago

Note - we need this for #24

sroberts commented 9 years ago

So I really like this, but I really don't like the idea of including the Maxmind DB in the repo. I'd much rather build in a function to fetch it if it's not there and make sure it's up to date. But my issue, probably should be my PR.

krmaxwell commented 9 years ago

I agree, originally this was because we were having trouble with TravisCI. Not sure if we want this to get re-DLed every time we do unit testing, although I'm also not sure about how smart the CircleCI build cache is.