search

yolothreat / utilitybelt

A Python library for being a CND Batman....
MIT License
35 stars 12 forks source link

adds support for isc/dshield query of an ip address #44

Closed jeffbryner closed 9 years ago

jeffbryner commented 9 years ago

spare time on a sunday to contribute the 'lil code attached herein.

krmaxwell commented 9 years ago

No test? :(

jeffbryner commented 9 years ago

I tested it, it works...trust me :-)

On May 3, 2015 5:32:05 PM PDT, Kyle Maxwell notifications@github.com wrote:

No test? :(

Reply to this email directly or view it on GitHub: https://github.com/yolothreat/utilitybelt/pull/44#issuecomment-98560261

Sent from my Android device with K-9 Mail. Please excuse my brevity.

jeffbryner commented 9 years ago

test added

sroberts commented 9 years ago

Did something break CI?

krmaxwell commented 9 years ago

It's a PR and not in our repo. That should be semi-fixed momentarily when I pull it into a branch from his fork.

lrn2github

sroberts commented 9 years ago

Hmmmm that seems like a config issue. It should be doing that.

krmaxwell commented 9 years ago

Passes now, still at :100: % coverage, no linter issues.

:+1:

sroberts commented 9 years ago