search

yomaytk / elfconv

An experimental AOT compiler that translates Linux ELF binary to WebAssembly
Apache License 2.0
148 stars 6 forks source link

`scripts/build.sh` should be executed during `docker build` rather than `docker run` #38

Closed AkihiroSuda closed 2 months ago

AkihiroSuda commented 2 months ago

Is there any reason to omit scripts/build.sh from the Dockerfile's RUN steps?

AkihiroSuda commented 2 months ago

I also suggest to remove integration tests from the default ENTRYPOINT script, as it takes more than 10 minutes.

yomaytk commented 2 months ago

Thank you for your suggestion!

Is there any reason to omit scripts/build.sh from the Dockerfile's RUN steps? I also suggest to remove integration tests from the default ENTRYPOINT script, as it takes more than 10 minutes.

As you say, it would be better to run scripts/build.sh during the container image build, and to separate the integration test from the ENTRYPOINT. Thanks.

@AkihiroSuda Could you open a PR for this issue? if not, I will deal with it.

AkihiroSuda commented 2 months ago