search

yomguy / DeeFuzzer

Light and instant media streaming client for web radios and TVs written in Python
https://github.com/yomguy/DeeFuzzer
GNU General Public License v3.0
141 stars 31 forks source link

mountpoint name is back with ".mp3" ".ogg" #66

Closed ChoiZ closed 9 years ago

ChoiZ commented 9 years ago

The extension ".mp3" is back on mountpoint name in 0.7 ;)

We remove it in 0.6.6.

achbed commented 9 years ago

It's not present on my config. Are you specifying one in the config file?

ChoiZ commented 9 years ago

I think no, I only add serverdefault node and update media, dir to source. It's the same config i use for 0.6.6

achbed commented 9 years ago

Whats' in the serverdefault node?

yomguy commented 9 years ago

Maybe we should set the whole mountpoint explicitely in the config, i.e. replacing shortname by mountpoint?

achbed commented 9 years ago

The logic on mountpoint naming in 0.7 is as follows: Use station:server:mountpoint if specified, OR Use station:info:short_name if specified, OR Use the string default.

Appending the media type is now set by the station:server:appendtype option. Set it to 1 to append the media format to the end of the specified mountpoint (ie, /station.mp3). Set to 0 to suppress it (ie, /station). Default is 1 (append it).

yomguy commented 9 years ago

Oh yes, I forgot this new option, perfect @achbed ;)

achbed commented 9 years ago

Should the default be 0 instead (if 0.6.6 did indeed change behavior to suppress)?

yomguy commented 9 years ago

Maybe yes because it seems that Itunes and other nasty player have bugs with streams urls including an extension. @ChoiZ can you confirm this?

achbed commented 9 years ago

See #68 - default for appendtype is now 0 (suppress output) to match readme notes from 0.6.6

ChoiZ commented 9 years ago

Nice it's works like a charm.