search

yomidevs / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.21k stars 93 forks source link

Don't scan user specified characters/symbols (Android) #1449

Open shiki-tm opened 2 weeks ago

shiki-tm commented 2 weeks ago

I notice on my phone on some websites when I touch some text or miss the text as is pretty common on touch screens sometimes, some random stuff like punctuation or even unseeable text elements(?) trigger a popup. For example: Screenshot_20240925_182526_Kiwi Browser Screenshot_20240925_182705_Kiwi Browser

Instead of adding them to regex and replacing with a whitespace which just causes other issues like connecting words and characters to the next sentence, can there be a feature where the user just adds to a list of things they don't want to ever be scanned and trigger a popup?

There's clearly some things that don't ever need to be scanned but this depends on the user.

Kuuuube commented 2 weeks ago

Since you appear to be using Yomitan for a language with kanji. You can disable Search text with non-Japanese, Chinese, or Cantonese characters and it should resolve this issue.

shiki-tm commented 2 weeks ago

After turning off the setting and refreshing tabs it is still possible for some symbols to show up

Screenshot_20241001_092258_Kiwi Browser

tadorituki commented 10 hours ago

hi does this issue still occour when using a different kanji dictionary, such as KANJIDIC i suspect this might just be wiktionary漢字 having incorrectly added entries

tadorituki commented 10 hours ago

maybe another option for scanning non-japanese text? something like