[BUG] Reordering while importing messes up dictionary list

yomidevs / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.

https://yomitan.wiki

GNU General Public License v3.0

1.31k stars 103 forks source link

Closed iamllama closed 6 days ago

iamllama commented 3 weeks ago

Description

I reordered my dictionaries while importing 三省堂国語辞典 (was at step 8/8 iirc, race condition maybe), and somehow my list ended up duplicated like this:

Deleting one of the JPDBs resulted in:

Browser version Firefox 133

Yomitan version 24.10.7.1

MarvNC commented 3 weeks ago

Does it stay messed up after restarting the extension/your browser? I think I've seen this bug before but it didn't leave any lasting damage.

iamllama commented 3 weeks ago

It fixed itself after I removed a dict, didn't get an opportunity to check if restarting or disabling would've fixed it :/

Kuuuube commented 3 weeks ago

Just refreshing the page should fix this.

iamllama commented 3 weeks ago

Just refreshing the page should fix this.

Came across it again (en/disabling instead of reordering) and refreshing did fix it 😅

EDIT: It happened again without me even touching anything during the import. Odd

EDIT2: 4th time its happened, 2nd time without any input and this time it has quadrupled after importing

khaitruong922 commented 3 weeks ago

tried to reorder the dictionaries while importing but cannot reproduce this issue

Kuuuube commented 6 days ago

Closing this as it is not really fixable due to how we have to handle settings to not break things across browsers.

Also possibly related to #957.