search

yomidevs / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.31k stars 103 forks source link

Remove touchInputEnabled and pointerEventsEnabled #1576

Closed jamesmaa closed 2 weeks ago

jamesmaa commented 3 weeks ago

Fixes #466

I just followed instructions of removing the option and related code and very lightly tested functionality

codspeed-hq[bot] commented 3 weeks ago

CodSpeed Performance Report

Merging #1576 will not alter performance

Comparing jamesmaa:remove-scan-inputs (ac98aa6) with master (77edfc7)

Summary

✅ 3 untouched benchmarks

github-actions[bot] commented 3 weeks ago

Playwright test results

failed  1 failed
passed  4 passed

Details

stats  5 tests across 4 suites
duration  4 minutes, 44 seconds
commit  77edfc7

Failed tests chromium › visual.spec.js › visual
MarvNC commented 2 weeks ago

Closing in favor of #1585