Remove touchInputEnabled and pointerEventsEnabled

yomidevs / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.

https://yomitan.wiki

GNU General Public License v3.0

1.31k stars 101 forks source link

Closed khaitruong922 closed 22 hours ago

khaitruong922 commented 2 weeks ago

Fixes #466

Additional changes to #1576:

github-actions[bot] commented 2 weeks ago

failed 1 failed
passed 4 passed

stats 5 tests across 4 suites
4 minutes, 42 seconds
commit 77edfc7

Failed tests

chromium › visual.spec.js › visual

khaitruong922 commented 2 weeks ago

click is triggering twice when switching from desktop to mobile mode on chrome dev tools

Kuuuube commented 2 weeks ago

This will break touch tap.

codspeed-hq[bot] commented 2 weeks ago

_{Comparing khaitruong922:remove-input-events-options (2e88bdd) with master (77edfc7)}

❌ 1 (👁 1) regressions
✅ 2 untouched benchmarks

	Benchmark	`master`	`khaitruong922:remove-input-events-options`	Change
👁	`japanese transformations-full (n=212)`	48.4 ms	61.8 ms	-21.69%