yomidevs / yomitan

Pop-up dictionary browser extension. Successor to Yomichan.
https://yomitan.wiki
GNU General Public License v3.0
1.29k stars 100 forks source link

Add Prettier config #517

Open piercemorris opened 10 months ago

piercemorris commented 10 months ago

To enable consistent auto-formatting to the repository in order to streamline PRs and development. Prettier should read from the already configured .eslintrc.json file. Prettier plugins are recommended to enable this behaviour.

We could also raise a discussion around current rules if there's capacity.

Casheeew commented 10 months ago

stylistic (which we are already using the ts plugin) also has indentation rules: https://eslint.style/rules/js/indent eol: https://eslint.style/rules/js/eol-last

jamesmaa commented 2 months ago

done

MarvNC commented 1 month ago

Was only enabled for markdown, would be nice to have it for everything else.

djahandarie commented 1 month ago

https://prettier.io/docs/en/integrating-with-linters.html is probably a relevant article if this is the direction we want to go.

We would need to remove all the stylistic stuff in our current eslint. Also need to remove lots of the formatting related stuff in vscode settings, and install properly extensions automatically for it to be smooth for new contributors