search

yomorun / hashids-java

Hashids algorithm v1.0.0 implementation in Java
http://hashids.org
MIT License
1.02k stars 156 forks source link

base58 alphabet #46

Closed vkorobkov closed 7 years ago

vkorobkov commented 7 years ago

Hi,

What do you think about adding a constant(public final static string BASE_58 = ...) with base58(https://en.wikipedia.org/wiki/Base58) alphabet right into Hashids class?

Base58 alphabet looks very well to be used in url paths because it excludes many confusions when letters are different but seem similar visually(0 (zero), O (capital o), I (capital i) and l (lower case L) )

If you like this idea, I can prepare small a PR. THanks

0x3333 commented 7 years ago

Hi! I believe that this is out of scope of the project. This can be easily implemented by the end-user. Despite that, I believe we could add this info in the README. Thanks.