One of my "pet peeves", incorrect ordering of arguments to assertion libraries, it's an easily made mistake when switching between projects that use junit or hamcrest or AssertJ, etc. When submitting
my other PR I noticed that some tests used the correct ordering and some
used the correct ordering so I thought that while it is Hacktober I may as well make another contribution.
If you would prefer a refactor to Hamcrest/AssertJ style assertions I could look into that too but it didn't seem worth it for such a small library.
Added a couple of very small stylistic commits in the same PR.
0x3333
commented
5 years ago
One of my "pet peeves", incorrect ordering of arguments to assertion libraries, it's an easily made mistake when switching between projects that use junit or hamcrest or AssertJ, etc. When submitting my other PR I noticed that some tests used the correct ordering and some used the correct ordering so I thought that while it is Hacktober I may as well make another contribution.
If you would prefer a refactor to Hamcrest/AssertJ style assertions I could look into that too but it didn't seem worth it for such a small library.
Added a couple of very small stylistic commits in the same PR.