search

yomorun / hashids-java

Hashids algorithm v1.0.0 implementation in Java
http://hashids.org
MIT License
1.02k stars 156 forks source link

Using StringBuilder for performance improvements #77

Closed lukechen116 closed 10 months ago

lukechen116 commented 10 months ago

In loops and recursion, using StringBuilder instead of String to reduce the creation and destruction of String objects can improve performance.

fanweixiao commented 10 months ago

Hi @lukechen116, would you mind provide your email, or, you can email me at fanweixiao#gmail.com.

0x3333 commented 10 months ago

Hi @lukechen116 , thanks for your contribution!

Unfortunately, your commit is a little polluted. Looks like your IDE is formatting the code in a different format(Especially indentation, 4 vs 2 spaces). Also, it's important to keep the PR to the topic, without other changes, which keeps the review process complex and difficult to track.

lukechen116 commented 10 months ago

Thank you for your correction. I will reformat and resubmit the pull request.