meshwalk.js updated three.js

yomotsu / meshwalk

for your TPS game development with three.js.

240 stars 42 forks source link

meshwalk.js updated three.js #3

Closed nutiler closed 6 years ago

nutiler commented 6 years ago

Hello!

This is such a great repository for game, unit collision, controls, and more! I started to work on a project using meshwalk.js and saw there were a few depreciated methods while updating from three.js r73+. I went ahead and updated it to the latest version of three.js which is r88 dev but I do not believe anything else will depreciate in the near future.

Some things such as Three.WireFrameHelper I commented out so all of the examples don't have any warnings or errors as I'll get to updating those using Three.WireFrameGeometry.

I updated the README for all of the changes.

Please review this pull and let me know if you have any questions!

Thanks,

Josh Wilson josh@stormheart.net

yomotsu commented 6 years ago

@nutiler Thanks for your contribution!

I wonder if you could load three.js from CDN. Could you change for all examples and delete three.js from this repo? Because it will cause large diff everytime.🙇 https://cdnjs.com/libraries/three.js/

Can we use es6-promise-auto instead of Bluebird.js? What we need is just loading following script instead of bluebard.js. Then, bluebird section in readme.md can be removed. (promise is already standard feature!) https://cdnjs.cloudflare.com/ajax/libs/es6-promise/4.1.1/es6-promise.auto.min.js

I think we should have own EventDispacher in MeshWalk under MW namespace. I will prepare it later. In meantime, can we use THREE.EventDispatcher.prototype in three.js instead of external libraly?

nutiler commented 6 years ago

@yomotsu

We can definitely switch to CDN's it will make it much smaller and cleaner as well, I'll be sure to do this next time I'm free. That's a great idea for promise-auto if we can make this more dependant on itself the better!