search

yomybaby / atom-titanium

[DEPRECATED] Atom package for Titanium Alloy
https://atom.io/packages/titanium-alloy
MIT License
49 stars 11 forks source link

TextEditor.get is deprecated. #54

Closed vsantana closed 7 years ago

vsantana commented 7 years ago

TextEditor.prototype.displayBuffer has always been private, but now it is gone. Reading the displayBuffer property now returns a reference to the containing TextEditor, which now provides some of the API of the defunct DisplayBuffer class.

TextEditor.get (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor.js:101:14)
Object.getFileEditor (/Users/vsantana/.atom/packages/titanium-alloy/lib/ti-pkg-util.js:15:55)
findDefinition (/Users/vsantana/.atom/packages/titanium-alloy/lib/clickProvider.js:366:27)
<unknown> (/Users/vsantana/.atom/packages/titanium-alloy/lib/clickProvider.js:444:38)
Function._.each._.forEach (/Users/vsantana/.atom/packages/titanium-alloy/node_modules/underscore/underscore.js:153:9)
Object.getSuggestionForWord (/Users/vsantana/.atom/packages/titanium-alloy/lib/clickProvider.js:443:9)
yomybaby commented 7 years ago

Thanks for reporting! 👍 I just removed dependency on displayBuffer.

m1ga commented 7 years ago

The message still shows up. https://github.com/yomybaby/atom-titanium/blob/master/lib/ti-pkg-util.js#L15 still has displayBuffer

yomybaby commented 7 years ago

@m1ga I removed that also. :)