Closed Yuni-sa closed 10 months ago
Attention: 106 lines
in your changes are missing coverage. Please review.
Comparison is base (
15c865e
) 46.33% compared to head (f3b3a3d
) 45.87%.
Files | Patch % | Lines |
---|---|---|
pkg/kor/finalizers.go | 37.50% | 46 Missing and 4 partials :warning: |
pkg/kor/delete.go | 50.87% | 25 Missing and 3 partials :warning: |
pkg/kor/kor.go | 0.00% | 28 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@Yuni-sa is this ready for review?
Overall it looks good. Can we support this in multi and all and merge the namespaces? Maybe we can do it that way and then put finalizers as include finalizers flag or something like that?
WDYT?
Not sure if there is a good implementation of this without #167 , after reasoning will be added I will create a new pr that will include it in all and multi.
if we add this now it would probably all be deleted/changed in the next pr, I think the current implementation of using kor finalizers
which also supports all of the filters options is fine for now.
Overall it looks good. Can we support this in multi and all and merge the namespaces? Maybe we can do it that way and then put finalizers as include finalizers flag or something like that? WDYT?
Not sure if there is a good implementation of this without #167 , after reasoning will be added I will create a new pr that will include it in all and multi.
if we add this now it would probably all be deleted/changed in the next pr, I think the current implementation of using
kor finalizers
which also supports all of the filters options is fine for now.
Ok. Can you just add the command in the Readme and then we can merge it
Iterates over all types of namespaced resources in the cluster (Including Custom Resources) check if they are in a terminating state by looking if they have a finalizer and a deletion timestamp, deletion of those resources is also supported by patching out the finalizer.
part of #117
this command is not added to the "all" command for future plans implementing a separate function for the supported resources after #167