Closed hagay3 closed 9 months ago
Can you please add this to https://github.com/yonahd/kor/blob/main/pkg/kor/delete.go https://github.com/yonahd/kor/blob/main/pkg/kor/multi.go And also add tests similar to the role function?
@yonahd let me know if you have any other feedback
@yonahd waiting for CI approval
@yonahd waiting for CI approval
Looks like it's still failing on things that needed to be changed based on recent changes
@yonahd another CI approval ...
@yonahd I'm not sure what is the issue with linting ?
@yonahd I'm not sure what is the issue with linting ?
Hey From a quick look you are taking a value for err and not using it (the error should be handled)
@yonahd hopefully now i'll pass ..
Attention: 62 lines
in your changes are missing coverage. Please review.
Comparison is base (
910be54
) 44.61% compared to head (c880a17
) 45.36%.
Files | Patch % | Lines |
---|---|---|
pkg/kor/clusterroles.go | 62.00% | 25 Missing and 13 partials :warning: |
pkg/kor/all.go | 0.00% | 13 Missing :warning: |
pkg/kor/delete.go | 0.00% | 7 Missing :warning: |
pkg/kor/multi.go | 0.00% | 4 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@doronkg thanks for the review, fixed :)
fixes #66