search

yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
974 stars 91 forks source link

Map false unused resources: Kind #235

Closed yonahd closed 4 months ago

yonahd commented 5 months ago

Find all default resources in a kind cluster that kor flags as unused. List them Create an issue to exclude them Bonus: Open merge request with the exclusions (example can be found here)

doronkg commented 5 months ago

/assign

yonahd commented 5 months ago

I have docker.io-hostpath in kind (macos)

doronkg commented 5 months ago

As mentioned in https://github.com/yonahd/kor/pull/241#issuecomment-2077220002, multiple resources are similar between minikube & kind.

@yonahd should I append the differences to the existing exclusion lists for each resource, or await #253?

doronkg commented 5 months ago

I have docker.io-hostpath in kind (macos)

I can perform checks both for Windows & Linux installations, but don't have MacOS, so I'll add that. Have we performed minikube checks for all these distributions as well? @cecobask

cecobask commented 5 months ago

Hi @doronkg,

I tested the minikube changes on a MacOS only. Might have to investigate further in a separate ticket. Feel free to open up an issue and I can pick it up soon.

doronkg commented 5 months ago

Hi @doronkg,

I tested the minikube changes on a MacOS only. Might have to investigate further in a separate ticket. Feel free to open up an issue and I can pick it up soon.

I can take a look on the other OSs for minikube and see if additional resources should be excluded.

I'd appreciate if you can assist me with checking kind on MacOS after I'll submit the basic PR to see if more resources should be excluded.

yonahd commented 5 months ago

Hi @doronkg, I tested the minikube changes on a MacOS only. Might have to investigate further in a separate ticket. Feel free to open up an issue and I can pick it up soon.

I can take a look on the other OSs for minikube and see if additional resources should be excluded.

I'd appreciate if you can assist me with checking kind on MacOS after I'll submit the basic PR to see if more resources should be excluded.

I'll make sure you get it all from macos

doronkg commented 5 months ago

As mentioned in https://github.com/yonahd/kor/pull/241#issuecomment-2077220002, multiple resources are similar between minikube & kind.

@yonahd should I append the differences to the existing exclusion lists for each resource, or await #253?

@yonahd

yonahd commented 5 months ago

As mentioned in #241 (comment), multiple resources are similar between minikube & kind. @yonahd should I append the differences to the existing exclusion lists for each resource, or await #253?

@yonahd

Go ahead with appending. The refactor should be very simple

doronkg commented 4 months ago

I've tested kind both on Windows & Linux, and all the default unused resources are covered (from source, not via v0.3.8). The only difference is mentioned here but it was added in #252. If additional resources are mapped on MacOS, I'll submit a PR to exclude them, if not, this issue could be closed.

yonahd commented 4 months ago

service: docker.io-hostpath in kube-system Thats the only missing one in macos

doronkg commented 4 months ago

Hi @doronkg, I tested the minikube changes on a MacOS only. Might have to investigate further in a separate ticket. Feel free to open up an issue and I can pick it up soon.

I can take a look on the other OSs for minikube and see if additional resources should be excluded.

I've checked, no additional exceptions where found for minikube on Windows/Linux.