search

yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
974 stars 91 forks source link

refactor: map false minikube unused resources #241

Closed cecobask closed 5 months ago

cecobask commented 5 months ago

Fixes #238

doronkg commented 5 months ago

This PR also covers #235 almost completely. I've created a default kind cluster and ran kor all right away. All the unused ClusterRoles, ConfigMaps, Secrets & StorageClasses are mapped in this PR, but for one ClusterRole.

The ClusterRole system:persistent-volume-provisioner is created in both distros, but by default:

@yonahd would you prefer that I'll submit a different PR for that or rather should we include the single difference in this PR?

yonahd commented 5 months ago

This PR also covers #235 almost completely. I've created a default kind cluster and ran kor all right away. All the unused ClusterRoles, ConfigMaps, Secrets & StorageClasses are mapped in this PR, but for one ClusterRole.

The ClusterRole system:persistent-volume-provisioner is created in both distros, but by default:

  • In minikube it is used by the storage-provisioner ClusterRoleBinding.
  • In kind it is unused by any RB/CRB.

@yonahd would you prefer that I'll submit a different PR for that or rather should we include the single difference in this PR?

@doronkg there are not some docker related configmaps specific to kind?

doronkg commented 5 months ago

@doronkg there are not some docker related configmaps specific to kind?

All the ConfigMaps are the same between kind & minikube on default installations.

yonahd commented 5 months ago

@doronkg there are not some docker related configmaps specific to kind?

All the ConfigMaps are the same between kind & minikube on default installations.

Moving this discussion to the relevant ticket.

cecobask commented 5 months ago

@yonahd, I rebased my branch with the latest changes and fixed the lint issues. Please, take a look when you get a chance and let me know if something else is left to be done here 👍