yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
974 stars 91 forks source link

Refactor: move resource exceptions to external files #253

Closed yonahd closed 5 months ago

yonahd commented 5 months ago

Move the resource exceptions to a different file.

Currently the lists of exception resource are quite long e.g. https://github.com/yonahd/kor/blob/main/pkg/kor/configmaps.go#L17 and will cause future contributors more cognitive load.

We should separate these from the actual code

pbr0ck3r commented 5 months ago

It might be nice to also break out resources into their individual clouds (then merge them all together) using a helper function. We can better track changes related to specific environments this way and also allow targeting specific environments.

yonahd commented 5 months ago

It might be nice to also break out resources into their individual clouds (then merge them all together) using a helper function. We can better track changes related to specific environments this way and also allow targeting specific environments.

  • pkg

    • exceptions

    • gke

    • aks

    • kind

    • minikube

    • universal (i.e. kube-proxy)

I was thinking of splitting it using the resource type but this might make more sense. Let's see if there are any takers and we'll see how simply it can be done

pbr0ck3r commented 5 months ago

Happy to take a initial stab at this.

yonahd commented 5 months ago

Go for it. Let's see how it looks