Closed cecobask closed 4 months ago
Attention: Patch coverage is 38.16514%
with 337 lines
in your changes are missing coverage. Please review.
Project coverage is 40.83%. Comparing base (
97d3873
) to head (db62e9a
). Report is 1 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @cecobask thanks for this contribution! #43 was long overdue, I'll review it as soon as I can.
From a glimpse it seems to me that this PR also resolves an issue with excessive newline padding in default table
output.
In the meantime, please udpate README.md
with the --group-by
flag and output examples.
Thank you, @doronkg! I've updated the documentation as suggested and rebased the branch.
Thank you, @doronkg! I've updated the documentation as suggested and rebased the branch.
Great, I've reviewed the main refactor in all.go
- looks good, moving to the resource-based refactors & tests.
It seems that many additions such as object literal restructuring were generated by IDE (?), it makes the code much more readable.
Great, I've reviewed the main refactor in
all.go
- looks good, moving to the resource-based refactors & tests. It seems that many additions such as object literal restructuring were generated by IDE (?), it makes the code much more readable.
Yes, the IDE I'm using (GoLand) is quite opinionated about code formatting. It makes sense to enforce this style, although I don't know which golangci-lint
rule can address that.
What this PR does / why we need it
Adds a new flag
--group-by
to all subcommands of kor. The value must be one ofnamespace
orresource
. Please review the changes first; if all looks good, I will add tests.PR Checklist
Github Issue
Closes #43
Notes for your reviewers
kor all --group-by=resource
:kor all --group-by=namespace
: