yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
1.04k stars 96 forks source link

feat(helm): Add Extra Labels to Helm Chart for Enhanced Metadata Management #265

Closed matazr closed 6 months ago

matazr commented 6 months ago

What this PR does / why we need it

This pull request enhances the Helm chart within the Kor project by adding extra labels to the metadata. This update improves the flexibility and organization of Kubernetes resource management.

Changes Made

Benefits

PR Checklist

Please review the changes and provide feedback. If there are any questions or further modifications needed, feel free to let me know. Thank you for your time and consideration in reviewing this pull request.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.83%. Comparing base (6a391d3) to head (d0d5d04). Report is 1 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #265 +/- ## ======================================= Coverage 40.83% 40.83% ======================================= Files 58 58 Lines 2902 2902 ======================================= Hits 1185 1185 Misses 1531 1531 Partials 186 186 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

doronkg commented 6 months ago

Hi @matazr, although the PR was merged, there're several disparities with README.

The AppVersion still points to v0.3.4, and many keys refer to prometheusExporter.service rather than prometheusExporter.serviceMonitor.

matazr commented 6 months ago

@doronkg thanks for your feedback. I put this PR can you review as well?