Closed matazr closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 40.83%. Comparing base (
6a391d3
) to head (d0d5d04
). Report is 1 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @matazr, although the PR was merged, there're several disparities with README.
The AppVersion
still points to v0.3.4, and many keys refer to prometheusExporter.service
rather than prometheusExporter.serviceMonitor
.
What this PR does / why we need it
This pull request enhances the Helm chart within the Kor project by adding extra labels to the metadata. This update improves the flexibility and organization of Kubernetes resource management.
Changes Made
_helpers.tpl
file to include additional labels.spec.template.metadata.labels
: Ensured that the labels are correctly placed within the Helm chart's metadata._helpers.tpl
:Benefits
PR Checklist
[ ] This PR adds K8s exceptions (false positives)
[ ] This PR adds new code
[ ] This PR includes tests for any new code
Files Affected:
templates/_helpers.tpl
templates/deployment.yaml
templates/cronjob.yaml
values.yaml
Please review the changes and provide feedback. If there are any questions or further modifications needed, feel free to let me know. Thank you for your time and consideration in reviewing this pull request.