Feat: add failed jobs as unused

yonahd commented 4 months ago

This PR adds a case where A Job has failed and reached it's maximum retries. This pod should now be considered unused

What this PR does / why we need it?

PR Checklist

[ ] This PR adds K8s exceptions (false positives)
[x] This PR adds new code
[x] This PR includes tests for new/existing code
[ ] This PR adds docs

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.96%. Comparing base (710239d) to head (72e1cab). Report is 3 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #283 +/- ## ========================================== + Coverage 40.84% 40.96% +0.12% ========================================== Files 58 58 Lines 2904 2910 +6 ========================================== + Hits 1186 1192 +6 Misses 1530 1530 Partials 188 188 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

doronkg commented 4 months ago

Left small suggestion. Few thoughts, as we're shifting the way we approach unused Jobs from just completed ones:

If adding failures as an indication for unused, let's add another condition for DeadlineExceeded.
We can also consider checking FailedIndexes which is another type of BackoffLimit.
What about suspended Jobs?

yonahd / kor