fix(helm): Add missing labels key in metadata

idfer commented 4 months ago

What this PR does / why we need it?

Fix missing labels key on cronjob.yaml that cause YAML parse error when run helm command.

PR Checklist

[ ] This PR adds K8s exceptions (false positives)
[ ] This PR adds new code
[ ] This PR includes tests for new/existing code
[ ] This PR adds docs
[x] This PR fix helm chart template error

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.96%. Comparing base (5b9c270) to head (e734cbb).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #292 +/- ## ======================================= Coverage 40.96% 40.96% ======================================= Files 58 58 Lines 2910 2910 ======================================= Hits 1192 1192 Misses 1530 1530 Partials 188 188 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yonahd commented 4 months ago

Thanks! Would you like to take on this https://github.com/yonahd/kor/issues/286 So things like this don't reaccur It can be in a separate pr

found-it commented 4 months ago

@yonahd any chance we can merge this PR? I added some helm chart testing and if all goes to plan, it'll block until these fixes are in

yonahd / kor