search

yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
1.04k stars 96 forks source link

Feature: exception sorting as makefile targets #298

Closed Itaykal closed 5 months ago

Itaykal commented 5 months ago

What this PR does / why we need it?

This PR adds two Makefile targets, one for validating the exception files' sorting, and the other to sort them recursively. I took the code added in #295 and converted it to targets, thus simplifying both the Github action and the developer's workflow.

PR Checklist

GitHub Issue

[XX-XX]

Notes for your reviewers

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.92%. Comparing base (5b9c270) to head (1081d30). Report is 6 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #298 +/- ## ========================================== - Coverage 40.96% 40.92% -0.05% ========================================== Files 58 58 Lines 2910 2913 +3 ========================================== Hits 1192 1192 - Misses 1530 1532 +2 - Partials 188 189 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.