search

yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
1.04k stars 96 forks source link

feature: Enhance unused Jobs discovery #315

Closed doronkg closed 3 months ago

doronkg commented 5 months ago

Following #283, we added another indication for unused Jobs for Job that had reached BackoffLimit and failed.

Add the following indications to enhance the discovery:

  1. Jobs that failed with DeadlineExceeded.
  2. Job that failed with FailedIndexes which is another type of BackoffLimit.
  3. Suspended Jobs.
nati-elmaliach commented 3 months ago

Hey 👋 I’ll be happy to take this on. @doronkg , should this be three separate PRs or a single one?

doronkg commented 3 months ago

Hey 👋 I’ll be happy to take this on. @doronkg , should this be three separate PRs or a single one?

Hey @nati-elmaliach, thanks for reaching out to contribute!

One PR that includes all three indications is fine, just make sure to cover everything with tests and differentiate the reasons why the job was considered unused.

Feel free to consult with us regarding the implementation and share your perspective on the scope of the issue.

@yonahd please assign the issue.