search

yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
1.04k stars 96 forks source link

Feature: Change NoInteractive flag to NonInteractive #333

Open jodybro opened 3 months ago

jodybro commented 3 months ago

Is your feature request related to a problem? Please describe. No. Purely syntactical

Describe the solution you'd like The flag to switch to non-interactive mode to be --non-interactive vs --nointeractive

Additional context First off...I love this tool. It's able to fix things that other colleagues/friends can struggle with for hours in a matter of a few seconds. I meant to make this request a while ago when I first found this tool but I completely forgot.

Basically the first time that I used it and wanted to delete resources noninteractively I typed --non-interactive off muscle memory vs the --no-interactive flag right now. I even checked the help output beforehand to make sure there was an automated process for resource deletion and everything but still used the former flag since most cli tools that can switch action modes standardize on that name.

jodybro commented 3 months ago

Btw if yall want I can handle the refactor since it would be super simple

yonahd commented 3 months ago

Hi Happy you are finding kor useful! 🙂

We're open to this change but we would like to support the old version as well in this upcoming release and just print a deprecation notice on it.

If you would like to take this I'll assign it to you

jodybro commented 3 months ago

@yonahd Yeah that sounds great! Do you have a version in mind to fully deprecate the flag? Or do you want a simple "This flag will be deprecated in favor of --non-interactive in a future release"?

yonahd commented 3 months ago

@jodybro v0.6.0

jodybro commented 3 months ago

Gotcha @yonahd!

yonahd commented 1 month ago

@jodybro do you still want to handle this one?