yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
1.04k stars 96 forks source link

Feat/Support for Argo Rollouts #363

Closed oliveiraxavier closed 1 month ago

oliveiraxavier commented 1 month ago

What this PR does / why we need it?

PR Checklist

This PR adds support for rollout type types (Argo Rollouts)

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 30.24390% with 143 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (673c21e) to head (1babf0e).

Files with missing lines Patch % Lines
pkg/kor/delete.go 1.53% 64 Missing :warning:
pkg/kor/argorollouts.go 54.16% 15 Missing and 7 partials :warning:
pkg/kor/all.go 11.76% 15 Missing :warning:
cmd/kor/argorollouts.go 0.00% 10 Missing :warning:
pkg/kor/kor.go 0.00% 10 Missing :warning:
pkg/kor/exporter.go 0.00% 7 Missing :warning:
pkg/kor/multi.go 40.00% 6 Missing :warning:
cmd/kor/all.go 0.00% 2 Missing :warning:
cmd/kor/deployments.go 0.00% 2 Missing :warning:
cmd/kor/exporter.go 0.00% 2 Missing :warning:
... and 2 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #363 +/- ## ========================================== - Coverage 44.48% 43.65% -0.84% ========================================== Files 63 65 +2 Lines 3356 3530 +174 ========================================== + Hits 1493 1541 +48 - Misses 1622 1741 +119 - Partials 241 248 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yonahd commented 1 month ago

I like the direction of this PR, still need to get around to a code review... On a more general level,

oliveiraxavier commented 1 month ago

Gosto da direção deste PR, ainda preciso fazer uma revisão de código... Em um nível mais geral,

  • Quero colocar o código crds em uma pasta separada dos recursos regulares
  • ao chamar, kor allquero mostrar apenas recursos nativos e mostrar cordões usando um sinalizador--include-crds
  • precisamos ter certeza de que o kor não travará quando este crd não existir no cluster

I understood. I liked your idea. Can I work on this? If you agree, I will close this PR

yonahd commented 1 month ago

Gosto da direção deste PR, ainda preciso fazer uma revisão de código... Em um nível mais geral,

  • Quero colocar o código crds em uma pasta separada dos recursos regulares
  • ao chamar, kor allquero mostrar apenas recursos nativos e mostrar cordões usando um sinalizador--include-crds
  • precisamos ter certeza de que o kor não travará quando este crd não existir no cluster

I understood. I liked your idea. Can I work on this? If you agree, I will close this PR

Yes. You can make these changes in this PR and this will be the first crd