yonahd / kor

A Golang Tool to discover unused Kubernetes Resources
MIT License
1.04k stars 96 forks source link

Adding option for podAnnotations on the deployment level #376

Open DMSwimTech opened 1 week ago

DMSwimTech commented 1 week ago

What this PR does / why we need it?

Currently the project support integration with Prometheus out of the box. To allow other provider such Datadog to collect metric we need to provide podAnnotation field Datadog annotations integration

PR Checklist

GitHub Issue

Closes [XX-XX]

Notes for your reviewers

yonahd commented 1 week ago

@DMSwimTech Thanks for the contribution. Can you bump the chart version? This is a requirement for any chart changes

codecov-commenter commented 1 week ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.38%. Comparing base (9cd0aba) to head (0f4d310). Report is 2 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #376 +/- ## ======================================= Coverage 43.38% 43.38% ======================================= Files 63 63 Lines 4020 4020 ======================================= Hits 1744 1744 Misses 2030 2030 Partials 246 246 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.