Closed tapoton closed 4 years ago
I think it’s a great addition ! I did often do it in my template too.
Please consider updating the Changelog and Readme files.
I will even propose it to enable by default.
Thanks for tour contribution @tapoton.
Hi @tapoton, thanks for the PR! As @mackoj noted could you please also add:
Hi!
Added necessary changes, enabled anyType: AnyCodable
override in default template
Looks like all changes made by FixturesTests
are valid. Please, take a look
FWIW I have no authority to do code review I'm just trying to helping you.
Please @tapoton could you consider moving it default value to Any
as @yonaskolb requested and I think you will be in a good place ;).
And add a small comment behind the configuration in Templates/Swift/template.yml
.
Thanks,
My bad, didn't get that at first. Done
@tapoton should your feature use the same option as codableResponses
? Because the goal of codableResponses
is to made the model Codable.
I think this can stay separate to codableResponses
Added anyType template option to be able to replace, for example
Any
or[String: Any]
withAnyCodable
and[String: AnyCodable]
.Did not find a way to do it using only template.