Sanitize the ends of folder source paths

yonaskolb / XcodeGen

A Swift command line tool for generating your Xcode project

MIT License

7.01k stars 818 forks source link

Sanitize the ends of folder source paths #1341

Closed ghost closed 1 year ago

ghost commented 1 year ago

Setting the source: /foo/bar is sometimes different from /foo/bar/ even if bar is a folder in both cases. The result of this is that we often run into a race condition where we have two objects with the same hash but different properties. This fixes #1339 and #1131.

dalemyers commented 1 year ago

I've created this with my work account, but I've referenced this account in the README as this is what I'd prefer to link to long term.

ghost commented 1 year ago

I've added the sanitization to the constructors. Regarding the tests, I'm not really sure what the options are here? I couldn't reproduce this every time no matter what I tried. Personally, I'd rather skip it than add a knowingly flaky test.