yonaskolb / XcodeGen

A Swift command line tool for generating your Xcode project
MIT License
7.01k stars 818 forks source link

Add possiblity to add resources before the sources build phase #1351

Closed mat1th closed 1 year ago

mat1th commented 1 year ago

Hello, this is my first contribution to this project. Thanks for your project!

Short description

XcodeGen doesn't support reordering the build phases of a target. This PR adds the possibility to move the "add resources" before the "sources build phase".

Background

As noted in #1042 it is sometimes needed to have the resources already moved before building the app to verify the resources compile time. In the same issue @yonaskolb did note that the way to go is adding a property on target. This PR does implement that.

Implementation

teameh commented 1 year ago

Nice work! Don't forget to:

mat1th commented 1 year ago

Thanks for the feedback.

I've resolved all issues. Could you recheck the pull request?

teameh commented 1 year ago

\0/ Nice!

mat1th commented 1 year ago

Thank you @yonaskolb for merging!