search

yonaskolb / XcodeGen

A Swift command line tool for generating your Xcode project
MIT License
6.88k stars 809 forks source link

Supports specifying multiple package products #1395

Closed simonbs closed 10 months ago

simonbs commented 10 months ago

Adds support for specifying multiple products for when adding a package dependency to a target.

With this change dependencies that were previously written as

dependencies:
- package: FooFeature
  product: FooDomain
- package: FooFeature
  product: FooUI

can now be written as

dependencies:
- package: FooFeature
  products: 
  - FooDomain
  - FooUI

This makes it easier to add multiple products of a single package.

simonbs commented 10 months ago

👍

Please add some test case under Fixtures, like: https://github.com/yonaskolb/XcodeGen/blob/master/Tests/Fixtures/SPM/project.yml

Sure! I'v added that in https://github.com/yonaskolb/XcodeGen/pull/1395/commits/be92f16155eed8dbe4a6e1f68f1fe847be131852.

yonaskolb commented 10 months ago

Looks good! Thanks @simonbs!