Remove the prefix v for the semantic version if necessary

yonaskolb / XcodeGen

A Swift command line tool for generating your Xcode project

MIT License

6.88k stars 809 forks source link

Remove the prefix v for the semantic version if necessary #1415

Closed coffmark closed 2 months ago

coffmark commented 8 months ago

Describe your changes

Remove the prefix v for the semantic version in SPM if necessary, as in v2.2.0.
- Libraries that include the prefix v in tags are Quick, Nimble, socket.io-client-swift

Issue ticket number and link

None. (as far as I've seen)

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests.

Thanks!

yonaskolb commented 4 months ago

@coffmark can you help me understand the issue? How does SPM manage this when you reference a dependency with and without v when the tag contains a v?

coffmark commented 2 months ago

In SPM, it outputs an error when the tag contains a v. I'm beginning to feel that my PR are not right. Thank you for your comments 🙏