tvOS Top Shelf is broken when using Xcodegen with Xcode 15

[clausjoergensen]

This used to work, but around when iOS 17 / Xcode 15 was introduced it broke along the way. We thought it was Apple who broken it (because there was bugs in 17.0), but it turns out that Xcodegen isn't handling it correctly.

I've made a sample project at https://github.com/clausjoergensen/TVOSXcodeGenSample that have a Xcode created MyProjectTVOSSample.xcodeproj version that works, and a project.yml that generates MyProjectTVOSXcodeGenSample.xcodeproj which doesn't.

I've not been able to pinpoint what the difference is, and the error produced by Xcode is, well, not very useful:

Snapshot request 0x600000c74ab0 complete with error: <NSError: 0x600000c50c00; domain: FBSSceneSnapshotErrorDomain; code: 4; "an unrelated condition or state was not satisfied"> {
    NSLocalizedDescription = an error occurred during a scene snapshotting operation;
}
Snapshot request 0x600000c71170 complete with error: <NSError: 0x600000c74a80; domain: FBSSceneSnapshotErrorDomain; code: 4; "an unrelated condition or state was not satisfied"> {
    NSLocalizedDescription = an error occurred during a scene snapshotting operation;
}

[clausjoergensen]

Hmm, using type: app-extension worked in the sample project, but something still broken in our main project. More research required, ignore for now!